🔧 [open-zaak/open-zaak#1629] Refactor settings module #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
feature/refactor-settings
branch
2 times, most recently
from
0e4f269 to
f3d54a4
Compare
use base settings from open-api-framework and add staging/production settings
* fix interpolation issue in docker-compose * upgrade postgres to 12 * add redis container * add DISABLE_2FA envvar * add CACHE_DEFAULT and CACHE_AXES
_fonts.scss relied on font assets that were in Django 2.2.x, but this causes errors when using ManifestStaticFilesStorage
as it was previously broken using 0.14.1
stevenbal
force-pushed
the
feature/refactor-settings
branch
from
fb186af to
95b0f4c
Compare
Coperh
approved these changes
May 10, 2024
annashamray
reviewed
May 10, 2024
| FIXTURE_DIRS = (os.path.join(DJANGO_PROJECT_DIR, "fixtures"),) | ||
|
|
||
| LOGGING_DIR = os.path.join(BASE_DIR, "log") | ||
| LANGUAGE_CODE = "en-us" # FIXME should this be "nl-nl"? |
There was a problem hiding this comment.
Good question! Maybe @joeribekker could help us?
* remove unused setting * add warning in changelog to add Redis
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially fixes open-zaak/open-zaak#1629
Related PR: maykinmedia/open-api-framework#19 (once that is merged, I'll do a release and remove the git dependency from Objecttypes)
I moved the settings from
base.pyto a genericbase.pyin Open API Framework (see maykinmedia/open-api-framework#19). I'm not sure if it will be possible to do the same for the environment specific settings (production, dev, docker etc.), but that might be worth looking into at some point.I also had to make several fixes with regards to the docker-compose setup and OIDC.
Some things that I noticed:
VERSION_TAG, I changed this toRELEASETIME_ZONEandLANGUAGE_CODEdiffer from Open Zaak